* fix: study list translations * Don't render until translations are ready * Try to wait for translations to load * Use null to render "nothing" * Try toggling useSuspense off up a layer * logging * Remove useSuspense false flags * DO NOT OPEN A PR WITH IT. Experimental changes only. Try to solve issues with useTranslation hooks #Please enter the commit message for your changes. Lines starting * Remove unecessary changes * feat: 🎸 useMedia hook to not use one more prop for upd state vl * docs: Add license scan report and status (#1161) Signed-off-by: fossabot <badges@fossa.io> * fix: 🐛 Fix for JS breaking on header (#1164) * feat: 🎸 Code review and refact Revised code based on PRs(variable alias,...). Changed hook for useMedia. Now, it provides two hooks: one to get displayMediaSize and other to get Entity(component, objects...) based on displayMediaSize. Implemented a similar solution for state manager to store mediaQueryList(s) and displaySize for app. * feat: 🎸 Fine tunning on mediaQuery value, fixed issue about it * fix: 🐛 Fixed issue and refactoring Fixed js exception and also refactoring userPreferences components to functional component * fix: 🐛 Code review. Localstorage fix minor bugs * fix: 🐛 Ensure hotkey lower case always * fix: translation switcher * chore(release): publish [skip ci] - @ohif/extension-vtk@0.53.6 - @ohif/ui@0.62.1 - @ohif/viewer@2.8.2 * Add new modal service * Change serviceManager prop to servicesManager * CR Update: fix casing and add required proptypes to providers * CR Update: Improve ohifmodal proptypes * CR Update: Fix typo in extensionmanager * CR Update: add default props to service and check service in provider * Refactor modal provider to better use its own state * ci: don't build our master branch (#1177) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * Use modal instead of modal context * Ci/promotable builds (#1179) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * ci: try building with QUICK_BUILD flag * Change modal children order * Ci/promotable builds (#1180) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * ci: try building with QUICK_BUILD flag * Try using ~/repo prefix in command * Ci/promotable builds (#1181) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * ci: try building with QUICK_BUILD flag * Try using ~/repo prefix in command * ci: make sure netlify command is available * Ci/promotable builds (#1182) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * ci: try building with QUICK_BUILD flag * Try using ~/repo prefix in command * ci: make sure netlify command is available * ci: use sudo for global command * Fix OHIFModal proptypes * Ci/promotable builds (#1183) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * ci: try building with QUICK_BUILD flag * Try using ~/repo prefix in command * ci: make sure netlify command is available * ci: use sudo for global command * Inline personal access token w/ env var * Ci/promotable builds (#1184) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * ci: try building with QUICK_BUILD flag * Try using ~/repo prefix in command * ci: make sure netlify command is available * ci: use sudo for global command * Inline personal access token w/ env var * ci: workaround for sudo limitations * ci: restore release workflow (#1185) * ci: don't build our master branch * Add netlify-cli as a dev dependency * ci: trying a sheltered merge flow for promotions * ci: try building with QUICK_BUILD flag * Try using ~/repo prefix in command * ci: make sure netlify command is available * ci: use sudo for global command * Inline personal access token w/ env var * ci: workaround for sudo limitations * ci: restore release workflow * Pass services to each module, improve tests * Add servicesManager test and registerServices method * Fix key warning of snackbar elements * Remove netlify-cli; we';ll install this on CI server * Update staging and prod netlify site IDs * Clean up NPM_PUBLISH step * Clean up DOCS_PUBLISH step * Clean up Deploy workflow * Custom executor to override cypress config * Spacing * Use an existing docker hub image * Switch to npx instead of digging into npm bin location * Remove e2e test before prod deploy * Add workflow images * docs: continous integrationn * Add default props to modal * chore(release): publish [skip ci] - @ohif/extension-cornerstone@1.5.1 - @ohif/extension-vtk@0.53.7 - @ohif/core@1.9.1 - @ohif/ui@0.62.2 - @ohif/viewer@2.8.3 * chore(release): publish [skip ci] - @ohif/extension-vtk@0.53.8 - @ohif/core@1.10.0 - @ohif/ui@0.62.3 - @ohif/viewer@2.8.4 * ci: Redirect site traffic to index.html if file is not resolved * ci: fix typo * fix: 🐛 Code review. Remove 'global state' for displaySize * fix: 🐛 Code review. Ref back to useMedia and pass value down Code review. Ref back to useMedia and pass value down (components) instead of creating a specialized hook to tied any component on it * fix: translation switcher * fix * cleanup * add missed translation * fix: 🐛 Code review * fix: 🐛 Fix unit tests * fix: 🐛 Fix unit test * fix: 🐛 Code merge solve conflicts. Missing files changes * Merge from master. Missing files changes * feat: 🎸 Code review. Fix issues with DatePicker Fixed at least the minimum issue with datePicker and update some content on every translation changed * fix: 🐛 Code review. Style fix on modal * fixes in general preferences after merge * fix * export default i18n language * translation fixes * increase snackbar zindex * initialize language * WIP propagate props<>state fixes * fix state propagation * remove hotkey error when reset default * fix datePicker * i18n updates * fix i18n strings * fix reset default -- set right input value * fix default language * fix e2e for user preferences * small fix datePicker props * remove i18n from window -- debugging purposes only * lint fixes
204 lines
6.2 KiB
JavaScript
204 lines
6.2 KiB
JavaScript
import CommandsManager from './CommandsManager.js';
|
|
import HotkeysManager from './HotkeysManager.js';
|
|
import hotkeys from './hotkeys';
|
|
import log from './../log.js';
|
|
|
|
jest.mock('./CommandsManager.js');
|
|
jest.mock('./hotkeys');
|
|
jest.mock('./../log.js');
|
|
|
|
describe('HotkeysManager', () => {
|
|
let hotkeysManager, commandsManager;
|
|
|
|
beforeEach(() => {
|
|
commandsManager = new CommandsManager();
|
|
hotkeysManager = new HotkeysManager(commandsManager);
|
|
CommandsManager.mockClear();
|
|
hotkeys.mockClear();
|
|
log.warn.mockClear();
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
it('has expected properties', () => {
|
|
const allProperties = Object.keys(hotkeysManager);
|
|
const expectedProprties = [
|
|
'hotkeyDefinitions',
|
|
'hotkeyDefaults',
|
|
'isEnabled',
|
|
];
|
|
|
|
const containsAllExpectedProperties = expectedProprties.every(expected =>
|
|
allProperties.includes(expected)
|
|
);
|
|
|
|
expect(containsAllExpectedProperties).toBe(true);
|
|
});
|
|
|
|
it('logs a warning if instantiated without a commandsManager', () => {
|
|
new HotkeysManager();
|
|
|
|
expect(log.warn.mock.calls.length).toBe(1);
|
|
expect(log.warn.mock.calls[0][0]).toEqual(
|
|
'HotkeysManager instantiated without a commandsManager. Hotkeys will be unable to find and run commands.'
|
|
);
|
|
});
|
|
|
|
describe('disable()', () => {
|
|
beforeEach(() => hotkeys.pause.mockClear());
|
|
|
|
it('sets isEnabled property to false', () => {
|
|
hotkeysManager.disable();
|
|
|
|
expect(hotkeysManager.isEnabled).toBe(false);
|
|
});
|
|
|
|
it('calls hotkeys.pause()', () => {
|
|
hotkeysManager.disable();
|
|
|
|
expect(hotkeys.pause.mock.calls.length).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe('enable()', () => {
|
|
beforeEach(() => hotkeys.unpause.mockClear());
|
|
|
|
it('sets isEnabled property to true', () => {
|
|
hotkeysManager.disable();
|
|
hotkeysManager.enable();
|
|
|
|
expect(hotkeysManager.isEnabled).toBe(true);
|
|
});
|
|
|
|
it('calls hotkeys.unpause()', () => {
|
|
hotkeysManager.enable();
|
|
|
|
expect(hotkeys.unpause.mock.calls.length).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe('setHotkeys()', () => {
|
|
it('calls registerHotkeys for each hotkeyDefinition', () => {
|
|
const hotkeyDefinitions = [
|
|
{ commandName: 'dance', label: 'dance dance', keys: '+' },
|
|
{ commandName: 'celebrate', label: 'celebrate everything', keys: 'q' },
|
|
];
|
|
|
|
hotkeysManager.registerHotkeys = jest.fn();
|
|
hotkeysManager.setHotkeys(hotkeyDefinitions);
|
|
|
|
const numberOfCalls = hotkeysManager.registerHotkeys.mock.calls.length;
|
|
const firstCallArgs = hotkeysManager.registerHotkeys.mock.calls[0][0];
|
|
const secondCallArgs = hotkeysManager.registerHotkeys.mock.calls[1][0];
|
|
|
|
expect(numberOfCalls).toBe(2);
|
|
expect(firstCallArgs).toEqual(hotkeyDefinitions[0]);
|
|
expect(secondCallArgs).toEqual(hotkeyDefinitions[1]);
|
|
});
|
|
it('does not set this.hotkeyDefaults when calling setHotKeys', () => {
|
|
const hotkeyDefinitions = [{ commandName: 'dance', keys: '+' }];
|
|
|
|
hotkeysManager.setHotkeys(hotkeyDefinitions);
|
|
|
|
expect(hotkeysManager.hotkeyDefaults).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe('setDefaultHotKeys()', () => {
|
|
it('it sets default hotkeys', () => {
|
|
const hotkeyDefinitions = [{ commandName: 'dance', keys: '+' }];
|
|
|
|
hotkeysManager.setDefaultHotKeys(hotkeyDefinitions);
|
|
|
|
expect(hotkeysManager.hotkeyDefaults).toEqual(hotkeyDefinitions);
|
|
});
|
|
});
|
|
|
|
describe('registerHotkeys()', () => {
|
|
it('logs a warning and returns undefined if a commandName is not provided', () => {
|
|
const definition = { commandName: undefined, keys: '+' };
|
|
|
|
const result = hotkeysManager.registerHotkeys(definition);
|
|
|
|
expect(result).toBe(undefined);
|
|
expect(log.warn.mock.calls.length).toBe(1);
|
|
});
|
|
it('updates hotkeyDefinitions property with registered keys', () => {
|
|
const definition = { commandName: 'dance', label: 'hello', keys: '+' };
|
|
const expectedHotkeyDefinition = { label: 'hello', keys: '+' };
|
|
|
|
hotkeysManager.registerHotkeys(definition);
|
|
|
|
const numOfHotkeyDefinitions = Object.keys(
|
|
hotkeysManager.hotkeyDefinitions
|
|
).length;
|
|
const hotkeyDefinitionForRegisteredCommand =
|
|
hotkeysManager.hotkeyDefinitions[definition.commandName];
|
|
|
|
expect(numOfHotkeyDefinitions).toBe(1);
|
|
expect(hotkeyDefinitionForRegisteredCommand).toEqual(
|
|
expectedHotkeyDefinition
|
|
);
|
|
});
|
|
it('calls hotkeys.bind for all keys in array', () => {
|
|
const definition = { commandName: 'dance', keys: ['h', 'e', 'l', 'o'] };
|
|
|
|
hotkeysManager.registerHotkeys(definition);
|
|
|
|
expect(hotkeys.bind.mock.calls.length).toBe(definition.keys.length);
|
|
definition.keys.forEach((key, i) =>
|
|
expect(hotkeys.bind.mock.calls[i][0]).toBe(key)
|
|
);
|
|
});
|
|
it('calls hotkeys.unbind if commandName was previously registered, for each previously registered set of keys', () => {
|
|
const firstDefinition = {
|
|
commandName: 'dance',
|
|
keys: ['h', 'e', 'l', 'o'],
|
|
};
|
|
const secondDefinition = { commandName: 'dance', keys: 'a' };
|
|
|
|
// First call
|
|
hotkeysManager.registerHotkeys(firstDefinition);
|
|
// Second call
|
|
hotkeysManager.registerHotkeys(secondDefinition);
|
|
|
|
expect(hotkeys.unbind.mock.calls.length).toBe(
|
|
firstDefinition.keys.length
|
|
);
|
|
firstDefinition.keys.forEach((key, i) =>
|
|
expect(hotkeys.unbind.mock.calls[i][0]).toBe(key)
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('restoreDefaults()', () => {
|
|
it('calls setHotkeys with hotkey defaults', () => {
|
|
hotkeysManager.setHotkeys = jest.fn();
|
|
|
|
hotkeysManager.restoreDefaultBindings();
|
|
|
|
expect(hotkeysManager.setHotkeys.mock.calls[0][0]).toEqual(
|
|
hotkeysManager.hotkeyDefaults
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('destroy()', () => {
|
|
it('clears default and definition properties', () => {
|
|
hotkeysManager.hotkeyDefaults = ['hotdog', 'jeremy', 'qasar'];
|
|
hotkeysManager.hotkeyDefinitions = {
|
|
hello: 'world',
|
|
};
|
|
|
|
hotkeysManager.destroy();
|
|
|
|
expect(hotkeysManager.hotkeyDefaults).toEqual([]);
|
|
expect(hotkeysManager.hotkeyDefinitions).toEqual({});
|
|
});
|
|
it('resets all hotkey bindings', () => {
|
|
hotkeysManager.destroy();
|
|
|
|
expect(hotkeys.reset.mock.calls.length).toEqual(1);
|
|
});
|
|
});
|
|
});
|