chore(release): publish [skip ci]

- @ohif/extension-vtk@0.50.4
 - @ohif/core@0.50.3
 - @ohif/viewer@0.50.8

docs/latest/contributing/testing.md

@@ -0,0 +1,145 @@
+# Contributing: Tests
+
+> Testing is an opinionated topic. Here is a rough overview of our testing
+> philosiphy. See something you want to discuss or think should be changed? Open
+> a PR and let's discuss.
+
+You're an engineer. You know how to write code, and writing tests isn't all that
+different. But do you know why we write tests? Do you know when to write one, or
+what kind of test to write? How do you know if a test is a _"good"_ test? This
+document's goal is to give you the tools you need to make those determinations.
+
+Okay. So why do we write tests? To increase our... **CONFIDENCE**
+
+- If I do a large refactor, does everything still work?
+- If I changed some critical piece of code, is it safe to push to production?
+
+Gaining the confidence we need to answer these questions after every change is
+costly. Good tests allow us to answer them without manual regression testing.
+What and how we choose to test to increase that confidence is nuanced.
+
+## Kinds of Tests
+
+Test's buy us confidence, but not all tests are created equal. Each kind of test
+has a different cost to write and maintain. An expensive test is worth it if it
+gives us confidence that a payment is processed, but it may not be the best
+choice for asserting an element's border color.
+
+| Test Type   | Example                                                                  | Speed            | Cost                                                                     |
+| ----------- | ------------------------------------------------------------------------ | ---------------- | ------------------------------------------------------------------------ |
+| Static      | `addNums(1, '2')` called with `string`, expected `int`.                  | :rocket: Instant | :money_with_wings:                                                       |
+| Unit        | `addNums(1, 2)` returns expected result `3`                              | :airplane: Fast  | :money_with_wings::money_with_wings:                                     |
+| Integration | Clicking "Sign In", navigates to the dashboard (mocked network requests) | :running: Okay   | :money_with_wings::money_with_wings::money_with_wings:                   |
+| End-to-end  | Clicking "Sign In", navigates to the dashboard (no mocks)                | :turtle: Slow    | :money_with_wings::money_with_wings::money_with_wings::money_with_wings: |
+
+- :rocket: Speed: How quickly tests run
+- :money_with_wings: Cost: Time to write, and to debug when broken (more points
+  of failure)
+
+### Static Code Analysis
+
+Modern tooling gives us this "for free". It can catch invalid regular
+expressions, unused variables, and guarantee we're calling methods/functions
+with the expected paramater types.
+
+Example Tooling:
+
+- [ESLint][eslint-rules]
+- [TypeScript][typescript-docs] or [Flow][flow-org]
+
+### Unit Tests
+
+The building blocks of our libraries and applications. For these, you'll often
+be testing a single function or method. Conceptually, this equates to:
+
+_Pure Function Test:_
+
+- If I call `sum(2, 2)`, I expect the output to be `4`
+
+_Side Effect Test:_
+
+- If I call `resetViewport(viewport)`, I expect `cornerstone.reset` to be called
+  with `viewport`
+
+#### When to use
+
+Anything that is exposed as public API should have unit tests.
+
+#### When to avoid
+
+You're actually testing implementation details. You're testing implementation
+details if:
+
+- Your test does something that the consumer of your code would never do.
+  - IE. Using a private function
+- A refactor can break your tests
+
+### Integration Tests
+
+We write integration tests to gain confidence that several units work together.
+Generally, we want to mock as little as possible for these tests. In practice,
+this means only mocking network requests.
+
+#### When to use
+
+...
+
+### End-to-End Tests
+
+These are the most expensive tests to write and maintain. Largely because, when
+they fail, they have the largest number of potential points of failure. So why
+do we write them? Because they also buy us the most confidence.
+
+#### When to use
+
+Mission critical features and functionality, or to cover a large breadth of
+functionality until unit tests catch up. Unsure if we should have a test for
+feature `X` or scenario `Y`? Open an issue and let's discuss.
+
+## Summary
+
+- Does your test increase confidence?
+- Does the test type chosen balance the cost-to-confidence ratio?
+
+## Further Reading
+
+### General
+
+- [Assert(js) Conf 2018 Talks][assert-js-talks]
+  - [Write tests. Not too many. Mostly integration.][kent-talk] - Kent C. Dodds
+  - [I see your point, but…][gleb-talk] - Gleb Bahmutov
+- [Static vs Unit vs Integration vs E2E Testing][kent-blog] - Kent C. Dodds
+  (Blog)
+
+### End-to-end Testing w/ Cypress
+
+- [Getting Started](https://docs.cypress.io/guides/overview/why-cypress.html)
+  - Be sure to check out `Getting Started` and `Core Concepts`
+- [Best Practices](https://docs.cypress.io/guides/references/best-practices.html)
+- [Example Recipes](https://docs.cypress.io/examples/examples/recipes.html)
+
+## Testing Dorito
+
+[![testing dorito][testing-dorito-img]][testing-dorito]
+
+<!--
+  Links
+  -->
+
+<!-- prettier-ignore-start -->
+[eslint-rules]: https://eslint.org/docs/rules/
+[typescript-docs]: https://www.typescriptlang.org/docs/home.html
+[flow-org]: https://flow.org/
+<!-- Talks -->
+[assert-js-talks]: https://www.youtube.com/playlist?list=PLZ66c9_z3umNSrKSb5cmpxdXZcIPNvKGw
+[kent-talk]: https://www.youtube.com/watch?list=PLV5CVI1eNcJgNqzNwcs4UKrlJdhfDjshf
+[gleb-talk]: https://www.youtube.com/watch?v=5FnalKRjpZk
+[kent-blog]: https://kentcdodds.com/blog/unit-vs-integration-vs-e2e-tests
+<!-- Images -->
+[testing-trophy]: https://twitter.com/kentcdodds/status/960723172591992832?ref_src=twsrc%5Etfw%7Ctwcamp%5Etweetembed%7Ctwterm%5E960723172591992832&ref_url=https%3A%2F%2Fkentcdodds.com%2Fblog%2Fwrite-tests
+[aaron-square]: https://twitter.com/Carofine247/status/966727489274961920
+[gleb-pyramid]: https://twitter.com/Carofine247/status/966764532046684160/photo/3
+[testing-pyramid]: https://dojo.ministryoftesting.com/dojo/lessons/the-mobile-test-pyramid
+[testing-dorito]: https://twitter.com/denvercoder/status/960752578198843392
+[testing-dorito-img]: https://pbs.twimg.com/media/DVVHXycUMAAcN-F?format=jpg&name=4096x4096
+<!-- prettier-ignore-end -->

extensions/vtk/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.50.4](https://github.com/OHIF/Viewers/compare/@ohif/extension-vtk@0.50.3...@ohif/extension-vtk@0.50.4) (2019-08-26)
+
+**Note:** Version bump only for package @ohif/extension-vtk
+
+
+
+
+
 ## [0.50.3](https://github.com/OHIF/Viewers/compare/@ohif/extension-vtk@0.50.2...@ohif/extension-vtk@0.50.3) (2019-08-22)
 
 **Note:** Version bump only for package @ohif/extension-vtk

extensions/vtk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ohif/extension-vtk",
-  "version": "0.50.3",
+  "version": "0.50.4",
   "description": "OHIF extension for VTK.js",
   "author": "OHIF",
   "license": "MIT",
@@ -52,7 +52,7 @@
     "vtk.js": "^9.5.0"
   },
   "devDependencies": {
-    "@ohif/core": "^0.50.2",
+    "@ohif/core": "^0.50.3",
     "@ohif/ui": "^0.50.1",
     "cornerstone-tools": "^3.13.0",
     "cornerstone-wado-image-loader": "^3.0.0",

platform/core/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.50.3](https://github.com/OHIF/Viewers/compare/@ohif/core@0.50.2...@ohif/core@0.50.3) (2019-08-26)
+
+
+### Bug Fixes
+
+* **Studies:** Qidosupportsincludefield should be true by default ([#801](https://github.com/OHIF/Viewers/issues/801)) ([a88d865](https://github.com/OHIF/Viewers/commit/a88d865))
+
+
+
+
+
 ## [0.50.2](https://github.com/OHIF/Viewers/compare/@ohif/core@0.50.1...@ohif/core@0.50.2) (2019-08-22)
 
 **Note:** Version bump only for package @ohif/core

platform/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ohif/core",
-  "version": "0.50.2",
+  "version": "0.50.3",
   "description": "Generic business logic for web-based medical imaging applications",
   "author": "OHIF Core Team",
   "license": "MIT",

platform/core/src/studies/services/qido/studies.js

@@ -118,6 +118,10 @@ export default function Studies(server, filter) {
   };
 
   const dicomWeb = new api.DICOMwebClient(config);
+  server.qidoSupportsIncludeField =
+    server.qidoSupportsIncludeField === undefined
+      ? true
+      : server.qidoSupportsIncludeField;
   const queryParams = getQIDOQueryParams(
     filter,
     server.qidoSupportsIncludeField

platform/viewer/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.50.8](https://github.com/OHIF/Viewers/compare/@ohif/viewer@0.50.7...@ohif/viewer@0.50.8) (2019-08-26)
+
+**Note:** Version bump only for package @ohif/viewer
+
+
+
+
+
 ## [0.50.7](https://github.com/OHIF/Viewers/compare/@ohif/viewer@0.50.6...@ohif/viewer@0.50.7) (2019-08-22)
 
 

platform/viewer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ohif/viewer",
-  "version": "0.50.7",
+  "version": "0.50.8",
   "description": "OHIF Viewer",
   "author": "OHIF Contributors",
   "license": "MIT",
@@ -44,12 +44,12 @@
   },
   "dependencies": {
     "@babel/runtime": "^7.5.5",
-    "@ohif/core": "^0.50.2",
+    "@ohif/core": "^0.50.3",
     "@ohif/extension-cornerstone": "^0.50.1",
     "@ohif/extension-dicom-html": "^0.50.1",
     "@ohif/extension-dicom-microscopy": "^0.50.1",
     "@ohif/extension-dicom-pdf": "^0.50.1",
-    "@ohif/extension-vtk": "^0.50.3",
+    "@ohif/extension-vtk": "^0.50.4",
     "@ohif/i18n": "^0.50.1",
     "@ohif/ui": "^0.50.1",
     "@tanem/react-nprogress": "^1.1.25",