Commit Graph
526 Commits
Author SHA1 Message Date
Igor OctavianoandRodrigo Antinarelli 3e944780dc OHIF-332: Users should be able to see all available hotkeys and language settings in one place (#1895)
* OHIF-330: Update Modal Styles

* feat/ohif-332: finish raw ui

* feat/ohif-332: update mode configuration strategy

* feat/ohif-332: fix hotkey errors

* feat/ohif-332: update hotkey logic with recent merged changes

* feat/ohif-322: wrap

* feat/ohif-322: add disable state

* ohif-332: cr updates

* ohif-332: disable

* ohif-332: cr updates

* ohif-332: extract header component

* ohif-332: cr update to fix merge conflicts and design issue

Co-authored-by: Rodrigo Antinarelli <rodrigoantinarelli@gmail.com>
2020-08-19 15:02:59 -04:00
Igor Octaviano e4092d0349 OHIF-145: update study list title to sentence case (#1991) 2020-08-17 10:10:07 +02:00
Igor Octaviano ef163cd702 Fix broken UI package build (#1990)
* Use path instead of alias

* Add missing pacakges

* Use path in viewers

* Use path in contextProviders

* Add base to config

* Add conditionals for window

* Copy config to avoid breaking build

* Update and lock versions

* Update lock file

* Remove scaling config

* Fix broken versions of react date

* Fix broken dev
2020-08-14 14:25:08 -04:00
Igor Octaviano 5fbcec99f8 ohif-319: fix asc and desc order on sort label (#1974) 2020-08-07 09:03:30 +02:00
Igor Octaviano fe52037fc2 OHIF-299: Fix Study Date sorting on Study List when clicking the label (#1966) 2020-08-06 12:36:28 +02:00
Igor Octaviano 5a82e09e29 ohif-321: update study list sorting logic (#1964) 2020-08-06 10:34:11 +02:00
Igor Octaviano 2446f8b86c ohif-320: remove outline from span (#1965) 2020-08-06 10:33:00 +02:00
401a2e38c8 [OHIF-193 + OHIF-313] (#1955)
* create context menu

* OHIF-193: Add context menu integration with measurement service

* OHIF-193: Update comments

* OHIF-CR Update: Add requested updates

* CR Update: Update measurement service remove function

* CR Update: Update casing

* CR Updates

* Update cornerstone measurments when the label is edited in the measurement service.

* Implement click outside behavior

* Address reviewer comments.

Co-authored-by: Rodrigo Antinarelli <rodrigoantinarelli@gmail.com>
Co-authored-by: igoroctaviano <igoroctaviano@gmail.com>
2020-08-05 14:56:02 +02:00
Danny BrownandJames A. Petts 2a51d75f77 [OHIF-339] - workflow changes (#1931)
* workflow changes

* Cherry pick OHIF-310 into this PR.

* fix label bug and dead code

* remove comment

* Wire up CreateReportButton

* fix additionalFindingTypes + save interaction

* Remove unused createReportAsync call

* stub for report hydration prompt

* Update PR

* Remove debuggers

* push updated code

* Push updates

* push

* fix sidebar save

* enable tracking of new study or series

* fix for duplicate created report series in sidebard

* fix for unexpected viewport dialog after visiting study list then a new study

* Fix for hydration not marking multiple series as active

* Reviewer changes.

* Respond to final review comment, add series description setting for export.

Co-authored-by: James A. Petts <jamesapetts@gmail.com>
2020-08-04 11:11:23 +02:00
James Petts 5f487840a1 OHIF-325: Remove trailing zeroes from patient age (#1941) 2020-07-31 19:00:00 +02:00
Erik ZieglerandJames A. Petts 55cf9f2306 OHIF-285/OHIF-274: Fix default hanging of display sets into the ViewportGrid (#1917)
* OHIF-285/OHIF-274: Fix default hanging of display sets into the ViewportGrid

Co-authored-by: James A. Petts <jamesapetts@gmail.com>
2020-07-24 12:51:57 +02:00
Rodrigo Antinarelli 15f20b445b fix: OHIF-215 - Patient information should truncate w/ ellipsis instead of expanding box (#1875) 2020-07-22 22:04:05 +02:00
Rodrigo Antinarelli afcd3f5263 fix: OHIF-307 - Click outside patient info should close tooltip (#1886) 2020-07-22 21:07:20 +02:00
Rodrigo Antinarelli a6b7657840 OHIF-260 - "Clear Filters" button should not be visible on first load, when no filters are set (#1873) 2020-07-22 20:51:20 +02:00
Rodrigo AntinarelliandErik Ziegler 8ca3769ba1 OHIF-304 - Create TooltipClipboard component for copying from Study List (#1887)
* Create TooltipClipboard component

* basic doc page for TooltipClipboard

* enable clipboard tooltip for specific rows

* wrap component with tooltip clipboard

* remove logic from ui component

* set clipbboard message

* minor refactor to add a delay to show the tooltip clipboard

* delay to hide comment

* Remove titles which were interfering with tooltips

Co-authored-by: Erik Ziegler <erik.sweed@gmail.com>
2020-07-22 20:25:51 +02:00
Erik Ziegler 8c30b21471 OHIF-284: Fix jump to measurement breaking keyboard shortcuts (#1914) 2020-07-22 19:58:39 +02:00
Erik Ziegler f95a8c1530 fix: Use same config for branch deploys as for deploy previews (#1893)
* fix: Use same config for branch deploys as for deploy previews

* chore: remove unnecessary duplicate build-deploy-preview.sh file

* fix: Attempt to workaround Netlify cache issues for Lerna repos

* chore: Remove useless debug file

* fix: try to make Gatsby less slow
2020-07-22 19:41:10 +02:00
James PettsandDanny Brown a4f286feee [OHIF 284] - JumpToMeasurement + prevent layout change on scroll Prevent layout change on scroll (#1889)
* No more setting on debounce, jumpToMeasurement service set up.

* Fix bug causing a race condition sometimes if you click super fast.

* Optimise rendering of Tracking viewport slightly.

* element => targetElement

* Remove complete TODO

* Respond to reviewer comments.

* Fix e2e workflow.

* Fix regression that removed highlighting on jump to.

* Make sure jump to works from panel as well as viewport.

* Fix typo and remove debugger.

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
2020-07-22 19:40:40 +02:00
Igor Octaviano 4985fbf5a6 Disable canvas if not active (#1890) 2020-07-10 15:52:17 -04:00
Rodrigo Antinarelli 8b1a6b2acb feat: OHIF-331 - About Modal (#1894)
* OHIF-330: Update Modal Styles

* feat: OHIF-331 - About Modal

* add dynamic values for about modal

* fix icon
2020-07-10 15:49:53 -04:00
Rodrigo Antinarelli 89cbe5bf2e fix: OHIF-255 Fixes Thumbnail height for active item (#1876) 2020-07-10 14:52:58 -04:00
Rodrigo Antinarelli 436df9ed30 OHIF-330: Update Modal Styles (#1891) 2020-07-10 11:48:51 -04:00
Rodrigo Antinarelli b28a70520e fix: OHIF-219 - Viewport Labels should be sequential (#1881) 2020-07-10 16:06:45 +02:00
James Petts 25ded882ec Disable double click for now. (#1872) 2020-07-06 08:28:21 -04:00
James PettsandDanny Brown 14797a8973 [OHIF-261 & OHIF-262] (#1862)
* WIP

* Reset viewport grid on mode switch.

* Make lifecyclehooks distinct from modules. Add needed SR hydration state on creation.

* Update extensions/cornerstone/src/init.js

* Remove unused REMOVE_MEASUREMENT listener.

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
2020-07-03 19:18:59 +02:00
James PettsandDanny Brown 4dfe144bf8 [OHIF-251] - Double click to maximise viewport/ revert to previous layout. (#1860)
* WIP

* double click to maximise implemented at the viewport grid layer.

* Remove memory of cached layout when the layout is changed, or a different displaySet is set.

* WIP fix double click for cornerstone.

* Update CST

* Prevent maximising when double clicking the action bar

* Update extensions/dicom-sr/src/OHIFCornerstoneSRViewport.js

* Apply suggestions from code review

* Fix conflicts.

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
2020-07-03 19:12:33 +02:00
Igor Octaviano 11fbe4cf01 OHIF-223: Add "Clear" all measurements to annotation toolbar (#1861)
* Add clear button

* Use james event

* Create new commands module to default
2020-07-03 12:39:41 -04:00
Rodrigo AntinarelliandDanny Brown 0e6c9258b7 OHIF-202: Add tooltip for locked/unlocked SR viewport icon (#1858)
* OHIF-202: Add tooltip for locked/unlocked SR viewport icon

* fix edit margin

* Update platform/ui/src/components/ViewportActionBar/ViewportActionBar.jsx

* Apply suggestions from code review

* Fix tooltip (func comp)

* Don't render the `0` of data.length used to check a render condition

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
2020-07-02 23:58:50 -04:00
Rodrigo Antinarelli cf91b0f942 OHIF-252: "Recent" and "All" tabs should be disabled if there are no studies on their category (#1859)
* OHIF-252: "Recent" and "All" tabs should be disabled if there are no studies on their category

* fix button props and avoid onClick on disabled state
2020-07-02 23:26:06 -04:00
Rodrigo Antinarellianddannyrb 491afaa43d fix: UI tweaks to satisfy OHIF-161, OHIF-254, OHIF-167, OHIF-249, OHIF-170, OHIF-162
* add group hover for borderColor

* measurements action buttons hover state

* fixes and button/buttongroup/iconButton refactor

* OHIF-161: Fix Tracked/Untracked Text in Thumbnail's Tooltip

* OHIF-254: Format SR series date

* OHIF-167 - Fix Study Date Time format

* OHIF-249: Fix viewport border thickness and action bar min height

* pass viewportIdentificator to SR Thumbnail

* show tooltip when hover over the SR thumbnail

* OHIF-170: Display tooltip when hovering over an untracked series in the Viewport Action Bar

* Undo accidental date change

* Sneak in "Create Report" messaging for createReport notifications

* Fix text clipping

* Add no-select text styles for action bar, thumbnail, and thumbnail no image (sr)

* fix for OHIF-162

Modified to remove Viewport Identifier. Text now only reads: “Structured Report”This was partly to address a bug where the Viewport Identifier was incorrect for all but the first displayed SR. Component API changed for ThumbnailNoImage to accomodate any generic “modalityTooltip”

* Some ViewportPane resize magic

Co-authored-by: dannyrb <danny.ri.brown@gmail.com>
2020-07-02 21:41:55 -04:00
Igor OctavianoandDanny Brown a156eadcb7 OHIF-208 (#1842)
* Set measurement as active

* Add basic dialog component

* Update styles and prop types

* Jump to image

* Update dialog

* Format date

* Update summary to use primary modalities

* delete empty studySummary page

* add missing PropTypes import

* fix for accidental sync'd viewports

* CR Updates

* CR Update avoid cache of measurements

* Use get measurement

* Add comment to edit function

* Remove request and merge modalities from series

* Update dependency: react-cornerstone-viewport@2.3.9

react-cornerstone-viewport
  * @ohif/extension-cornerstone: 2.3.8 → 2.3.9
  * @ohif/extension-dicom-sr: 2.3.8 → 2.3.9

* Update extensions/measurement-tracking/src/panels/PanelMeasurementTableTracking/index.js

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>

* Add debugs

* remove console.debug

* Update frameindex to imageindex

* Use new rcv debounced function

* Fix hovering

* Update dialog text

* Dismiss dialogs on esc

* Update dependency: react-cornerstone-viewport@3.0.0

react-cornerstone-viewport
  * @ohif/extension-cornerstone: 2.3.9 → 3.0.0
  * @ohif/extension-dicom-sr: 2.3.9 → 3.0.0

* OHIF-237

* remove console.debug

* Remove dead code brought in from rebase

* EmptyViewport should not display a message

* Remove more dead code from rebase

* fix variable naming

* remove unused hook

* bump yarn lock

* formatting

* Add arrow dialog

* Filter based on trackedSeries

Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
2020-07-02 16:53:38 -04:00
Igor Octaviano ae05de18af Add truncate 2 lines class (#1853) 2020-07-02 10:41:53 -04:00
James Petts bc2bde890b OHIF-190 - Rehydrate PR (#1835)
* WIP rehydration.

* WIP OHIF-190 rehydrate.

* Remove debugger statements.

* Merge in and fix after OHIF-197 and OHIF-198

* Remove console.log

* Fix typo

* fix length tracking bug

* Respond to reviewer comments.
2020-07-01 11:08:56 +02:00
dannyrb b967d064f0 Tidying up naming 2020-06-30 20:49:37 -04:00
Rodrigo Antinarelli 4b8dcef956 Merge branch 'feat/v2-main' of https://github.com/OHIF/Viewers into fix/OHIF-37-thumbnailDoubleClick 2020-06-30 17:59:57 -03:00
Rodrigo Antinarelli 0f78ae3b57 fix: remove focus if clicked outside thumbnail 2020-06-30 17:53:36 -03:00
Rodrigo Antinarelli 520e1c0774 fix focus styles 2020-06-30 16:05:18 -03:00
Rodrigo Antinarelli 90ca52585a update thumbnail props 2020-06-30 15:57:24 -03:00
Rodrigo Antinarelli f08ce57c0c pass isActive prop 2020-06-30 15:54:34 -03:00
Rodrigo Antinarelli 34a9733dfe replace onClick for double click and styles fixes 2020-06-30 15:54:21 -03:00
Rodrigo Antinarelli cf30a6da88 define currentDisplaySetData in viewport grid provider 2020-06-30 15:53:57 -03:00
igoroctaviano 04baaf941b Update snackbar styles 2020-06-30 14:25:10 -03:00
igoroctaviano 5ca6757b44 Add error message of generate reportt 2020-06-30 14:02:23 -03:00
igoroctaviano d94bc2d5a2 Merge branch 'feat/v2-main' of github.com:OHIF/Viewers into feat/ohif-179 2020-06-30 12:43:19 -03:00
igoroctaviano 1bfb62d26d Add messages to sr pacs 2020-06-30 12:33:38 -03:00
James Petts 2c11609c55 OHIF-198 - Jump to thumbnail when a new displaySet is added (#1834)
* Viewport letter only in multi-viewport layout.

* If SliceThickness not available print N/A

* Create displaySet in local session on SR generation.

* Jump to thumbnail when a new displaySet is added with the madeInClient property.

* Check if scrollIntoView exists.
2020-06-30 17:27:35 +02:00
Danny Brown d5d219c271 Merge pull request #1831 from OHIF/feat/ohif-203
OHIF-203: Add new viewport overlay
2020-06-30 08:41:20 -04:00
James Petts d266b944c2 [OHIF-192] - Viewport letter only if using multiple viewport layout. (#1822)
* Viewport letter only in multi-viewport layout.

* If SliceThickness not available print N/A
2020-06-30 12:41:50 +02:00
dannyrb a0b0f365dd Handle for interaction outside of the ViewportDialog (default to cancel) 2020-06-29 23:29:40 -04:00
igoroctaviano 9e2ed50e79 add new overlay 2020-06-29 18:05:52 -03:00