Styling updates to prevent lesion dialogs from going off screen

Packages/lesiontracker/client/components/lesionLocationDialog/lesionLocationDialog.js

@@ -76,6 +76,14 @@ function getLesionLocationCallback(measurementData, eventData) {
         display: 'block'
     };
 
+    var pageHeight = $(window).height();
+    dialogProperty.top = Math.max(dialogProperty.top, 0);
+    dialogProperty.top = Math.min(dialogProperty.top, pageHeight - dialog.outerHeight());
+
+    var pageWidth = $(window).width();
+    dialogProperty.left = Math.max(dialogProperty.left, 0);
+    dialogProperty.left = Math.min(dialogProperty.left, pageWidth - dialog.outerWidth());
+
     // Device is touch device or not
     // If device is touch device, set position center of screen vertically and horizontally
     if (isTouchDevice()) {

Packages/lesiontracker/client/components/lesionLocationDialog/lesionLocationDialog.styl

@@ -7,18 +7,11 @@
   right: 0
   z-index: 100
   width: 300px
-  margin: auto
+  height: 130px
   border-radius: 5px
   padding: 10px 20px 10px 20px
   background-color: rgba(255,255,255,1)
 
-  /* dialogMobile is added to #lesionLocationDialog when touchDevices is detected */
-  .dialogMobile
-    margin: 0 auto
-    float: none
-    background-color: rgba(0,0,0,0.5)
-    text-align: center
-
   #closeLesionPopup
     outline: none
     border: none

Packages/lesiontracker/client/components/nonTargetLesionDialog/nonTargetLesionDialog.html

@@ -54,7 +54,7 @@
                     {{ #if code }}
                     <option value={{code}} selected={{selected}}>{{code}} - {{text}}</option>
                     {{ else }}
-                    <option value={{text}}} selected={{selected}}>{{text}}</option>
+                    <option value={{text}} selected={{selected}}>{{text}}</option>
                     {{ /if }}
                     {{ /each}}
                 </select>

Packages/lesiontracker/client/components/nonTargetLesionDialog/nonTargetLesionDialog.js

@@ -94,6 +94,14 @@ function getLesionLocationCallback(measurementData, eventData) {
         display: 'block'
     };
 
+    var pageHeight = $(window).height();
+    dialogProperty.top = Math.max(dialogProperty.top, 0);
+    dialogProperty.top = Math.min(dialogProperty.top, pageHeight - dialog.outerHeight());
+
+    var pageWidth = $(window).width();
+    dialogProperty.left = Math.max(dialogProperty.left, 0);
+    dialogProperty.left = Math.min(dialogProperty.left, pageWidth - dialog.outerWidth());
+
     // Device is touch device or not
     // If device is touch device, set position center of screen vertically and horizontally
     if (isTouchDevice()) {
@@ -103,6 +111,7 @@ function getLesionLocationCallback(measurementData, eventData) {
         dialogProperty.left = 0;
         dialogProperty.right = 0;
         dialogProperty.bottom = 0;
+        dialogProperty.margin = 'auto';
     }
 
     dialog.css(dialogProperty);

Packages/lesiontracker/client/components/nonTargetLesionDialog/nonTargetLesionDialog.styl

@@ -12,13 +12,6 @@
   padding: 10px 20px 10px 20px
   background-color: rgba(255,255,255,1)
 
-  /* dialogMobile is added to #nonTargetLesionLocationDialog when touchDevices is detected */
-  .dialogMobile
-    margin: 0 auto
-    float: none
-    background-color: rgba(0,0,0,0.5)
-    text-align: center
-
   #selectNonTargetLesionLocation, #selectNonTargetLesionLocationResponse
     width: 100%
 
@@ -27,4 +20,7 @@
 
   .locationOK
     text-align: center
-    
+
+/* dialogMobile is added to #nonTargetLesionLocationDialog when touchDevices is detected */
+.dialogMobile
+  margin: auto

Packages/lesiontracker/client/components/nonTargetResponseDialog/nonTargetResponseDialog.js

@@ -44,6 +44,14 @@ changeNonTargetResponse = function(measurementData, eventData, doneCallback) {
     } else {
         dialogProperty.top = eventData.currentPoints.page.y - dialog.outerHeight() - 40;
         dialogProperty.left = eventData.currentPoints.page.x - dialog.outerWidth() / 2;
+
+        var pageHeight = $(window).height();
+        dialogProperty.top = Math.max(dialogProperty.top, 0);
+        dialogProperty.top = Math.min(dialogProperty.top, pageHeight - dialog.outerHeight());
+
+        var pageWidth = $(window).width();
+        dialogProperty.left = Math.max(dialogProperty.left, 0);
+        dialogProperty.left = Math.min(dialogProperty.left, pageWidth - dialog.outerWidth());
     }
 
     dialog.css(dialogProperty);

Packages/lesiontracker/client/components/timepointTextDialog/timepointTextDialog.html

@@ -3,7 +3,8 @@
         <div class="timepointDialogContentWrapper">
             <div class="dialogContent">
                 <div class="timepointContent">
-                    <input type="checkbox" id="checkBoxBaseline" value="ok"><strong >Baseline</strong>
+                    <input type="checkbox" id="checkBoxBaseline" value="ok">
+                    <label for="checkBoxBaseline">Baseline</label>
                 </div>
             </div>
         </div>

Packages/lesiontracker/client/components/timepointTextDialog/timepointTextDialog.styl

@@ -1,4 +1,3 @@
-
 #timepointTextDialog
   display: none
   position: absolute
@@ -12,7 +11,6 @@
     background-color: rgba(255,255,255,1)
     border-top-left-radius: 5px
     border-top-right-radius: 5px
-    text-align: left
 
     .dialogContent
       margin: 0 auto