fix: download tool fixes & improvements (#1235)

* fix: download tool fixes & improvements

* fix filename error

* Create variable to track erros

* Fix small console error

* Fix all conflicts and merge changes from latest master with this PR's improvements

* Small improvement on select and textinput labels

* Add new icon for unlink

* Refactor on download image modal

* Adding loading screen

* Fix translation issue

* Fixing aspect Ratio and E2E tests

* Allow empty value without setting to 0

* Remove eslint comments

* Fixing typos

Co-authored-by: Gustavo André Lelis <galelis@gmail.com>
Co-authored-by: Danny Brown <danny.ri.brown@gmail.com>
This commit is contained in:
authored and GitHub committed 2020-01-29 22:39:44 -05:00
1 parent 96a8e26786
commit b9574b6efc
11 files changed
+380 -177

No files matched your search

@@ -16,14 +16,14 @@ describe('OHIF Download Snapshot File', () => {
.click();
});
it('checks displayed information for Tablet experience', function() {
it('checks displayed information for Tablet experience', function () {
// Set Tablet resolution
cy.viewport(1000, 660);
// Visual comparison
cy.screenshot('Download Image Modal - Tablet experience');
});
it('checks displayed information for Desktop experience', function() {
it('checks displayed information for Desktop experience', function () {
// Set Desktop resolution
cy.viewport(1750, 720);
// Visual comparison
@@ -52,7 +52,7 @@ describe('OHIF Download Snapshot File', () => {
.should('be.visible');
});
it('cancel changes on download modal', function() {
it('cancel changes on download modal', function () {
//Change Image Width, Filename and File Type
cy.get('[data-cy="image-width"]')
.clear()
@@ -91,7 +91,7 @@ describe('OHIF Download Snapshot File', () => {
// //Check error message
// });
it('checks if "Show Annotations" checkbox will display annotations', function() {
it('checks if "Show Annotations" checkbox will display annotations', function () {
// Close modal that is initially opened
cy.get('[data-cy="close-button"]').click();