fix(cli): better support for external modules and toolGroups in templates (#3364)

* choe(modes, components): improved readability

This commit includes changes to improve performance in the basic-dev-mode and Thumbnail components.
Additionally, a change in the webpack configuration file was made to ignore ".min.js.map" files.
The defaultDataSourceName was also added to several configuration files, and whiteLabeling code was removed
from the local_orthanc configuration file.

* fix(cli): better path management and add dependencies

* better docs

* add default tool group to the templates

* add review comments

* apply review comments

* try to fix test

* fix thumbnail in tests
This commit is contained in:
Alireza authored and GitHub committed 2023-05-08 15:49:28 -04:00
1 parent 187e6b5f30
commit 2f355fa158
26 files changed
+193 -142

No files matched your search

+12 -4
View File
@@ -1,4 +1,5 @@
import path from 'path';
import os from 'os';
function getPathQuestions(packageType) {
return [
@@ -6,7 +7,7 @@ function getPathQuestions(packageType) {
type: 'input',
name: 'name',
message: `What is the name of your ${packageType}?`,
validate: (input) => {
validate: input => {
if (!input) {
return 'Please enter a name';
}
@@ -17,8 +18,8 @@ function getPathQuestions(packageType) {
{
type: 'input',
name: 'baseDir',
message: `What is the target absolute path to create your ${packageType} (we recommend you do not use the OHIF ${packageType} folder (./${packageType}s) unless you are developing a core ${packageType}):`,
validate: (input) => {
message: `What is the target path to create your ${packageType} (we recommend you do not use the OHIF ${packageType} folder (./${packageType}s) unless you are developing a core ${packageType}):`,
validate: input => {
if (!input) {
console.log('Please provide a valid target directory path');
return;
@@ -26,7 +27,13 @@ function getPathQuestions(packageType) {
return true;
},
filter: (input, answers) => {
return path.resolve(input, answers.name);
// Replace ~ with the user's home directory
const expandedPath = input.replace(/^~(?=$|\/|\\)/, os.homedir());
// Resolve the path to an absolute path
const resolvedPath = path.resolve(expandedPath, answers.name);
return resolvedPath;
},
},
{
@@ -43,6 +50,7 @@ function getRepoQuestions(packageType) {
type: 'confirm',
name: 'gitRepository',
message: 'Should it be a git repository?',
default: false,
},
{
type: 'confirm',